Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6830b0ce039785115a687f151004ec19c9cc6ad3
      
https://github.com/WebKit/WebKit/commit/6830b0ce039785115a687f151004ec19c9cc6ad3
  Author: Ben Nham <[email protected]>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M Source/WebKit/Shared/WebPushDaemonConstants.h
    M Source/WebKit/webpushd/PushClientConnection.h
    M Source/WebKit/webpushd/PushClientConnection.messages.in
    M Source/WebKit/webpushd/PushClientConnection.mm
    M Source/WebKit/webpushd/WebPushDaemon.h
    M Source/WebKit/webpushd/WebPushDaemon.mm
    M Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  -----------
  Remove webpushd debug mode logging
https://bugs.webkit.org/show_bug.cgi?id=276189
rdar://131070043

Reviewed by Sihui Liu.

Remove broadcastDebugMessage and related IPCs from webpushd. They aren't really 
used. Log to the
regular system log instead.

* Source/WebKit/Shared/WebPushDaemonConstants.h:
* Source/WebKit/webpushd/PushClientConnection.h:
(WebPushD::PushClientConnection::debugModeIsEnabled const): Deleted.
* Source/WebKit/webpushd/PushClientConnection.messages.in:
* Source/WebKit/webpushd/PushClientConnection.mm:
(WebPushD::PushClientConnection::setHostAppAuditTokenData):
(WebPushD::PushClientConnection::getPushTopicsForTesting):
(WebPushD::PushClientConnection::connectionClosed):
(WebPushD::PushClientConnection::setPublicTokenForTesting):
(WebPushD::PushClientConnection::setDebugModeIsEnabled): Deleted.
(WebPushD::PushClientConnection::broadcastDebugMessage): Deleted.
(WebPushD::PushClientConnection::sendDebugMessage): Deleted.
* Source/WebKit/webpushd/WebPushDaemon.h:
* Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::WebPushDaemon::connectionAdded):
(WebPushD::WebPushDaemon::injectPushMessageForTesting):
(WebPushD::WebPushDaemon::injectEncryptedPushMessageForTesting):
(WebPushD::WebPushDaemon::notifyClientPushMessageIsAvailable):
(WebPushD::WebPushDaemon::getPendingPushMessages):
(WebPushD::WebPushDaemon::getPushTopicsForTesting):
(WebPushD::WebPushDaemon::setPublicTokenForTesting):
(WebPushD::WebPushDaemon::broadcastDebugMessage): Deleted.
(WebPushD::WebPushDaemon::broadcastAllConnectionIdentities): Deleted.
* Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm:
(WebPushTool::Connection::startDebugStreamAction):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(TestWebKitAPI::TEST(WebPushD, BasicCommunication)):

Canonical link: https://commits.webkit.org/280694@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to