Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f288b9088d1b74b980c3b7a8d5add134f7689bdb
https://github.com/WebKit/WebKit/commit/f288b9088d1b74b980c3b7a8d5add134f7689bdb
Author: Ryan Reno <[email protected]>
Date: 2024-07-09 (Tue, 09 Jul 2024)
Changed paths:
A
LayoutTests/media/media-source/remoteplayback-availability-callback-does-not-leak-expected.txt
A
LayoutTests/media/media-source/remoteplayback-availability-callback-does-not-leak.html
A
LayoutTests/media/media-source/resources/remoteplayback-watch-availability-frame.html
A
LayoutTests/platform/glib/media/media-source/remoteplayback-availability-callback-does-not-leak-expected.txt
M LayoutTests/resources/document-leak-test.js
M Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp
M Source/WebCore/Modules/remoteplayback/RemotePlayback.h
Log Message:
-----------
RemotePlayback watchAvailability callback can leak the Document object.
https://bugs.webkit.org/show_bug.cgi?id=276344
rdar://131345363
Reviewed by Ryosuke Niwa.
RemotePlayback's watchAvailibility callback can leak captures, including
the Document object, if cancelWatchAvailability is not called by the web
author. This change will clear all registered callbacks when
ActiveDOMObject::stop is called allowing the callback and captures to be
garbage collected.
*
LayoutTests/platform/glib/media/media-source/remoteplayback-availability-callback-does-not-leak-expected.txt:
Added.
*
LayoutTests/media/media-source/remoteplayback-availability-callback-does-not-leak-expected.txt:
Added.
*
LayoutTests/media/media-source/remoteplayback-availability-callback-does-not-leak.html:
*
LayoutTests/media/media-source/resources/remoteplayback-watch-availability-frame.html:
* LayoutTests/resources/document-leak-test.js:
(iframeSentMessage):
* Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp:
(WebCore::RemotePlayback::stop):
* Source/WebCore/Modules/remoteplayback/RemotePlayback.h:
Canonical link: https://commits.webkit.org/280799@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
