Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 306889650017bc78e563434ff46d5a2567735c8a
https://github.com/WebKit/WebKit/commit/306889650017bc78e563434ff46d5a2567735c8a
Author: Dana Estra <[email protected]>
Date: 2024-07-11 (Thu, 11 Jul 2024)
Changed paths:
M Source/WebCore/Modules/modern-media-controls/controls/media-controls.js
M Source/WebCore/Modules/modern-media-controls/media/media-controller.js
Log Message:
-----------
YouTube: Unable to move the volume slider by dragging after disabling Video
Viewer
https://bugs.webkit.org/show_bug.cgi?id=276496
rdar://128587639
Reviewed by Eric Carlson.
When entering fullscreen, we add a dragstart event listener to the window that
we never remove.
This makes it so that after we have exited fullscreen, the dragstart event
listener is still
active, and it has a side effect of making the elements on the page to be
draggable. This is
noticeable when the user is moving youtube's volume slider. Instead of this
moving the knob on
the slider, this drags an image of the slider.
To fix this, we should remove the dragstart event listener on the window when
we exit fullscreen.
This will remove the event listener's side effect that is causing this bug.
* Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:
(MediaControls.prototype.disable):
(MediaControls):
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype._updateControlsIfNeeded):
Canonical link: https://commits.webkit.org/280873@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
