Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 07fd7c7499a7c38e9794fe517374f03777bbe3db
https://github.com/WebKit/WebKit/commit/07fd7c7499a7c38e9794fe517374f03777bbe3db
Author: Jer Noble <[email protected]>
Date: 2024-07-12 (Fri, 12 Jul 2024)
Changed paths:
A
LayoutTests/media/now-playing-info-media-session-private-browsing-expected.txt
A LayoutTests/media/now-playing-info-media-session-private-browsing.html
A
LayoutTests/media/now-playing-info-media-session-suspend-playback-expected.txt
A LayoutTests/media/now-playing-info-media-session-suspend-playback.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/Modules/webaudio/AudioContext.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/html/MediaElementSession.cpp
M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
Log Message:
-----------
Resign Now Playing status when WKWebView suspends all media playback
https://bugs.webkit.org/show_bug.cgi?id=276133
rdar://129853095
Reviewed by Eric Carlson.
When a WKWebView suspensd all media playback, we should resign Now Playing
status (because
we can no longer resume playback from Now Playing controls). Additionally, when
the page is
ephemeral, we should not report the media metadata information to Now Playing.
*
LayoutTests/media/now-playing-info-media-session-private-browsing-expected.txt:
Added.
* LayoutTests/media/now-playing-info-media-session-private-browsing.html: Added.
*
LayoutTests/media/now-playing-info-media-session-suspend-playback-expected.txt:
Added.
* LayoutTests/media/now-playing-info-media-session-suspend-playback.html: Added.
* Source/WebCore/Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::isNowPlayingEligible const):
(WebCore::AudioContext::nowPlayingInfo const):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isNowPlayingEligible const):
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::computeNowPlayingInfo const):
* Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::updateNowPlayingInfo):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::suspendAllMediaPlayback):
(WebCore::Internals::resumeAllMediaPlayback):
(WebCore::Internals::nowPlayingMetadata const):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
Canonical link: https://commits.webkit.org/280914@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
