Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c10d17a101bc61cee49226fce14d3af312bc31b
      
https://github.com/WebKit/WebKit/commit/0c10d17a101bc61cee49226fce14d3af312bc31b
  Author: Matthew Finkel <[email protected]>
  Date:   2024-07-12 (Fri, 12 Jul 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm
    M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h
    M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm

  Log Message:
  -----------
  Fail subframe loads instead of showing Safe Browsing warning page
https://bugs.webkit.org/show_bug.cgi?id=275763
rdar://125737529

Reviewed by Alex Christensen.

Instead of showing the safe browsing warning page in an iframe, this change now
fails the load instead. This provides a better user experience and avoids
confusion around malicious subresources.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(TEST(SafeBrowsing, WKWebViewGoBackIFrame)):
* Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h:
* Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
(-[TestNavigationDelegate 
_webView:navigation:didFailProvisionalLoadInSubframe:withError:]):

Canonical link: https://commits.webkit.org/280923@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to