Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6910086011dac0a98069ee26156aecbe087dc367
https://github.com/WebKit/WebKit/commit/6910086011dac0a98069ee26156aecbe087dc367
Author: Wenson Hsieh <[email protected]>
Date: 2024-07-14 (Sun, 14 Jul 2024)
Changed paths:
M Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Tools/TestWebKitAPI/cocoa/ImageAnalysisTestingUtilities.mm
M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
Log Message:
-----------
[iPadOS] Plumb the image rect in root view space to VKCImageAnalysis when
long pressing a QR code
https://bugs.webkit.org/show_bug.cgi?id=276593
rdar://131643168
Reviewed by Richard Robinson.
Adopt the new `rectForMrcActionInPresentingViewController` property on
`VKCImageAnalysis` when
presenting a context menu for QR codes. This allows the `Add to Calendar`
action (which shows a
popover on iPad) to present from the long-pressed image, after the changes in
rdar://119388199.
* Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView updateImageAnalysisForContextMenuPresentation:elementBounds:]):
(-[WKContentView
_completeImageAnalysisRequestForContextMenu:requestIdentifier:hasTextResults:]):
Also move the call to `-updateImageAnalysisForContextMenuPresentation:` up
before we ask for
`-mrcMenu`, so that the rect for MRC menu actions is honored when VisionKit
creates the menu item.
(-[WKContentView updateImageAnalysisForContextMenuPresentation:]): Deleted.
* Tools/TestWebKitAPI/cocoa/ImageAnalysisTestingUtilities.mm:
* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
Canonical link: https://commits.webkit.org/280955@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
