Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60d010a4128bc3aef9b5f4867c487d5ff6722e24
      
https://github.com/WebKit/WebKit/commit/60d010a4128bc3aef9b5f4867c487d5ff6722e24
  Author: Alex Christensen <[email protected]>
  Date:   2024-07-15 (Mon, 15 Jul 2024)

  Changed paths:
    M 
Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp
    M 
Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h

  Log Message:
  -----------
  Null check fetch in WebSWServerToContextConnection destructor
https://bugs.webkit.org/show_bug.cgi?id=276557
rdar://131637662

Reviewed by Brady Eidson.

This fixes a crash during teardown I saw locally with this stack trace:

WebKit::ServiceWorkerFetchTask::contextClosed() + 68
WebKit::WebSWServerToContextConnection::~WebSWServerToContextConnection() + 176
WebKit::WebSWServerToContextConnection::operator 
delete(WebKit::WebSWServerToContextConnection*, std::destroying_delete_t, 
unsigned long) + 16
WebKit::NetworkConnectionToWebProcess::didClose(IPC::Connection&) + 108
WTF::Detail::CallableWrapper<IPC::Connection::dispatchDidCloseAndInvalidate()::$_0,
 void>::call() + 68
WTF::RunLoop::performWork() + 204
...

* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::~WebSWServerToContextConnection):
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:

Canonical link: https://commits.webkit.org/280972@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to