Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 809d9cfc50337a7ca0ca631e88157ca23ce4bbb6
https://github.com/WebKit/WebKit/commit/809d9cfc50337a7ca0ca631e88157ca23ce4bbb6
Author: Jer Noble <[email protected]>
Date: 2024-07-15 (Mon, 15 Jul 2024)
Changed paths:
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.h
M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm
Log Message:
-----------
[iOS] Fullscreen captions are cut off when video is "zoomed"
https://bugs.webkit.org/show_bug.cgi?id=276621
rdar://130994690
Reviewed by Andy Estes.
Promote "captionLayer" to be a first-class child of WebAVPlayerLayer. This
allows the captionLayer
to be resized separately from the video content. When the videoGravity changes,
the captionLayer
is resized to intersect the video contents bounds with the bounds of the
WebAVPlayerLayer itself.
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.h:
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm:
(-[WebAVPlayerLayer setCaptionsLayer:]):
(-[WebAVPlayerLayer captionsLayer]):
(-[WebAVPlayerLayer layoutSublayers]):
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.h:
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm:
(WebCore::VideoPresentationInterfaceAVKit::setupFullscreen):
(WebCore::VideoPresentationInterfaceAVKit::setupCaptionsLayer):
* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h:
* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm:
(WebCore::VideoPresentationInterfaceIOS::doSetup):
(WebCore::VideoPresentationInterfaceIOS::videoDimensionsChanged):
(WebCore::VideoPresentationInterfaceIOS::playerLayer const):
Canonical link: https://commits.webkit.org/280995@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
