Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4b87e63a3ac98eee1b88215bf03dea4f5c05623a
https://github.com/WebKit/WebKit/commit/4b87e63a3ac98eee1b88215bf03dea4f5c05623a
Author: Jer Noble <[email protected]>
Date: 2024-07-15 (Mon, 15 Jul 2024)
Changed paths:
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
Log Message:
-----------
[visionOS] Audio in background tabs coming from wrong spatial location
https://bugs.webkit.org/show_bug.cgi?id=276544
rdar://131470861
Reviewed by Eric Carlson.
A logic error in ::updateSpatialTrackingLabel() set the wrong label on
non-visible (backgrounded) WKWebViews.
The layer or renderer's spatialTrackingLabel should only be set to `nil` (the
default) when the MediaPlayer
both has a renderer, and is visible. If either of those conditions is not true,
the default spatial tracking
label (provided by either WKWebView's content view, or by the client) should be
used.
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateSpatialTrackingLabel):
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateSpatialTrackingLabel):
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::updateSpatialTrackingLabel):
Canonical link: https://commits.webkit.org/280997@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
