Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 25f0f294ef46a9560ceedc25efe211cb7c330068
https://github.com/WebKit/WebKit/commit/25f0f294ef46a9560ceedc25efe211cb7c330068
Author: Jer Noble <[email protected]>
Date: 2024-07-16 (Tue, 16 Jul 2024)
Changed paths:
M Source/WebCore/platform/cocoa/VideoFullscreenCaptions.h
M Source/WebCore/platform/cocoa/VideoFullscreenCaptions.mm
Log Message:
-----------
[visionOS] Cannot disable captions in native fullscreen
https://bugs.webkit.org/show_bug.cgi?id=276668
rdar://131477154
Reviewed by Andy Estes.
LinearMediaKit can un-hide the caption layer provided via Playable at any
point, so
setting the caption layer's `hidden` property is unreliable to actually hide
the layer.
In addition to hiding the layer, also remove the layer's contents (and store it
for
re-use later).
* Source/WebCore/platform/cocoa/VideoFullscreenCaptions.h:
* Source/WebCore/platform/cocoa/VideoFullscreenCaptions.mm:
(WebCore::VideoFullscreenCaptions::setTrackRepresentationImage):
(WebCore::VideoFullscreenCaptions::setTrackRepresentationHidden):
Canonical link: https://commits.webkit.org/281025@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
