Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 677b11ce01d0dca2299d9d6d0135dcde940f169b
https://github.com/WebKit/WebKit/commit/677b11ce01d0dca2299d9d6d0135dcde940f169b
Author: Andy Estes <[email protected]>
Date: 2024-07-16 (Tue, 16 Jul 2024)
Changed paths:
M Source/WebKit/UIProcess/ios/PageClientImplIOS.h
M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
Log Message:
-----------
[visionOS] Safari window is sometimes hidden after exiting element fullscreen
https://bugs.webkit.org/show_bug.cgi?id=276670
rdar://131617118
Reviewed by Jer Noble and Tim Horton.
In 277877@main a workaround was added to address an issue where the element
fullscreen window was
not frontmost after exiting docked fullscreen. In some circumstances, however,
exiting docked
fullscreen may also exit element fullscreen and this could result in a
transform with
`kOutgoingWindowZOffset` being set on the WKWebView's window *after*
WKFullScreenWindowControllerIOS
had already undid that transform. The result would be that the window remained
hidden even though
the element fullscreen window had been closed.
Since the workaround was added the underlying bug tracked by rdar://126894293
has been resolved.
Since the workaround is no longer necessary and causes the issue described
above, this change
removes it.
* Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didExitFullscreen): Deleted.
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController didExitFullscreen]): Deleted.
Canonical link: https://commits.webkit.org/281029@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes