Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7dacb873108c102a5c83ecc6a3c85f361446e678
https://github.com/WebKit/WebKit/commit/7dacb873108c102a5c83ecc6a3c85f361446e678
Author: Frédéric Wang <[email protected]>
Date: 2024-07-17 (Wed, 17 Jul 2024)
Changed paths:
R LayoutTests/mathml/presentation/roots.xhtml
R LayoutTests/platform/glib/mathml/presentation/roots-expected.txt
R LayoutTests/platform/gtk/mathml/presentation/roots-expected.png
R LayoutTests/platform/ios/mathml/presentation/roots-expected.png
R LayoutTests/platform/ios/mathml/presentation/roots-expected.txt
R LayoutTests/platform/mac/mathml/presentation/roots-expected.png
R LayoutTests/platform/mac/mathml/presentation/roots-expected.txt
R LayoutTests/platform/win/mathml/presentation/roots-expected.txt
Log Message:
-----------
Remove legacy MathML pixel test roots.xhtml
https://bugs.webkit.org/show_bug.cgi?id=276704
Reviewed by Rob Buis.
This is the only remaining pixel test from the legacy MathML
implementations in WebKit (before 2016):
- This test is really dependent on the system font used, which make it
confusing for developers (as rendering doesn't always match the
screenshots) and less robust.
- It contains a lot of mathematical constructions with radicals, but it's
difficult to understand what they verify exactly when it fails
compared to the more modern tests like reftest or testharness.js.
- Equivalent coverage is probably better obtained by these modern tests,
and by manually checking the rendering of public test pages such as
https://fred-wang.github.io/MathFonts/mozilla_mathml_test/
- It breaks quite frequently, and we generally just update the text
expectation for the render tree without trying to understand whether
there is a regression (the screenshots are often out-of-date).
It is causing more harm than good, so let's just remove it.
* LayoutTests/mathml/presentation/roots.xhtml: Removed.
* LayoutTests/platform/glib/mathml/presentation/roots-expected.txt: Removed.
* LayoutTests/platform/gtk/mathml/presentation/roots-expected.png: Removed.
* LayoutTests/platform/ios/mathml/presentation/roots-expected.png: Removed.
* LayoutTests/platform/ios/mathml/presentation/roots-expected.txt: Removed.
* LayoutTests/platform/mac/mathml/presentation/roots-expected.png: Removed.
* LayoutTests/platform/mac/mathml/presentation/roots-expected.txt: Removed.
* LayoutTests/platform/win/mathml/presentation/roots-expected.txt: Removed.
Canonical link: https://commits.webkit.org/281045@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
