Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6d1794a4fa3b868910b808953e9addf0decbf34e
https://github.com/WebKit/WebKit/commit/6d1794a4fa3b868910b808953e9addf0decbf34e
Author: Jer Noble <[email protected]>
Date: 2024-07-17 (Wed, 17 Jul 2024)
Changed paths:
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
Log Message:
-----------
[visionOS] Docked/fullscreen video is black after transitioning between
sources
https://bugs.webkit.org/show_bug.cgi?id=276672
rdar://130920732
Reviewed by Andy Estes.
A VideoTarget is retrieved (if available) in the constructor of a
MediaPlayerPrivateMediaSourceAVFObjC
and stored in m_videoTarget. However, this does not set the
`m_usingLinearMediaPlayer` ivar to true,
and thus `acceleratedVideoMode()` does not return the correct value.
When setting the initial video target, rather than changing the ivar directly,
just call setVideoTarget(),
which will do the right thing.
Drive-by fix: The same pattern exists in MediaPlayerPrivateWebM, so make the
same change there.
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::MediaPlayerPrivateWebM):
Canonical link: https://commits.webkit.org/281051@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
