Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b7c1f1bbf585929454f61d117285e97f12dc94c9
https://github.com/WebKit/WebKit/commit/b7c1f1bbf585929454f61d117285e97f12dc94c9
Author: Alan Baradlay <[email protected]>
Date: 2024-07-17 (Wed, 17 Jul 2024)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-flex-001-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-flex-002-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-flex-003-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-flex-004-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-flex-001-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-flex-002-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-flex-003-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-flex-004-expected.txt
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
Log Message:
-----------
[Flex] Fix
imported/w3c/web-platform-tests/css/css-flexbox/flexbox-baseline-multi-line-horiz-002.html
https://bugs.webkit.org/show_bug.cgi?id=276701
Reviewed by Antti Koivisto.
Add support for first/last baseline when flex-wrap is reversed. It simply means
that first/last baseline
should follow visual order (flex-wrap: reverse swaps the order meaning first
line is last, last is first etc).
(FIXME: Add support for row/column reverse)
* LayoutTests/TestExpectations: while now we actually match other engines,
expectation still produces incorrect result making this test fail.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::firstLineBaseline const):
(WebCore::RenderFlexibleBox::lastLineBaseline const):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::flexItemOnFirstFlexLineForBaseline const):
(WebCore::RenderFlexibleBox::flexItemOnLastFlexLineForBaseline const):
(WebCore::RenderFlexibleBox::baselineFlexItem const): Deleted.
* Source/WebCore/rendering/RenderFlexibleBox.h:
Canonical link: https://commits.webkit.org/281061@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
