Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eaf4e99ac1b02eb53f8b2f157a4c5bbec7cf2b68
      
https://github.com/WebKit/WebKit/commit/eaf4e99ac1b02eb53f8b2f157a4c5bbec7cf2b68
  Author: icesfont <[email protected]>
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-fallback-001-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-fallback-002-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt
    M LayoutTests/mathml/mathml-overflow-crash-expected.txt
    M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt
    M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt
    R 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-fallback-001-expected.txt
    R 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-fallback-002-expected.txt
    M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout-expected.txt
    M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt
    M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt
    M 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt
    M 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt
    R 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-fallback-001-expected.txt
    R 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-fallback-002-expected.txt
    M Source/WebCore/accessibility/AccessibilityMathMLElement.cpp
    M Source/WebCore/mathml/MathMLFractionElement.cpp
    M Source/WebCore/mathml/MathMLFractionElement.h
    M Source/WebCore/mathml/MathMLRowElement.cpp
    M Source/WebCore/mathml/MathMLScriptsElement.cpp
    M Source/WebCore/mathml/MathMLScriptsElement.h
    M Source/WebCore/rendering/RenderObject.h
    M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLBlock.h
    M Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLFraction.h
    M Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLScripts.h
    M Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp

  Log Message:
  -----------
  [MathML] Layout invalid markup as an <mrow> 
https://bugs.webkit.org/show_bug.cgi?id=123348

Reviewed by @fred-wang.

Upstream commit: 
https://github.com/web-platform-tests/wpt/commit/ad94cb830eef8b8ff67a41820b3a61519d6d2dbd

Change to make invalid MathML markup lay out as `mrow` by calling 
`RenderMathMLRow` methods when invalid. Additionally, make elements inheriting 
from `RenderMathMLRow` and `MathMLRowElement` explicitly override the methods 
that `RenderMathMLRow`/`MathMLRowElement` override in order to prevent elements 
erroneously behaving like `mrow`s when valid.

Remove the now unused `RenderMathMLBlock::layoutInvalidMarkup`.

Amend the check for validity in 
`RenderMathMLScripts::validateAndGetReferenceChildren` to match the spec [1].

Important relevant `mrow` fallback tests from WPT and update test expectations.

[1]: 
https://w3c.github.io/mathml-core/spec.html#prescripts-and-tensor-indices-mmultiscripts#:~:text=that%20is%20not%20an%20mprescripts%20element
Canonical link: https://commits.webkit.org/281218@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to