Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8f784559fcff723191d3190446e5762440b5d91
      
https://github.com/WebKit/WebKit/commit/b8f784559fcff723191d3190446e5762440b5d91
  Author: Yusuke Suzuki <[email protected]>
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
    M Source/JavaScriptCore/assembler/AbstractMacroAssembler.h
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp

  Log Message:
  -----------
  [JSC] Use emitStoreCallSiteIndex within main path of DirectCall
https://bugs.webkit.org/show_bug.cgi?id=277013
rdar://132412918

Reviewed by Mark Lam.

DirectCall's slow path is wrongly setting CallSiteIndex without taking care of 
tail-calls.
That was existing bug which should be fixed in the future, but as the result, 
if we go to the slow path once and returning back to the main path,
we are still using the wrongly set CallSiteIndex in the main path. This patch 
fixes that by setting the appropriate CallSiteIndex within the main path.
Also add SuppressRegisetrAllocationValidation and suppress DFG register 
allocation validation for this particular place since DFG register allocation 
validation
is broken and fires randomly for the legit case[1].

[1]: 
https://github.com/WebKit/WebKit/commit/dd1c094a5f04ea5a5f93e236ff3b4db43d85a226

* Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):

Canonical link: https://commits.webkit.org/281332@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to