Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a11cfdc1cd143c1bdbcc9cabfd97a15bb0b32a2e
https://github.com/WebKit/WebKit/commit/a11cfdc1cd143c1bdbcc9cabfd97a15bb0b32a2e
Author: Youenn Fablet <[email protected]>
Date: 2024-07-26 (Fri, 26 Jul 2024)
Changed paths:
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
Log Message:
-----------
AVVideoCaptureSource should not update torch while setting camera preset
rdar://132554327
https://bugs.webkit.org/show_bug.cgi?id=277128
Reviewed by Eric Carlson.
According testing, locking/unlocking an AVCaptureDevice within a session
configuration can lead to issues.
In AVVideoCaptureSource, this leads to torch being turned of right after being
turned off, if we change the camera preset at the same time.
To workaround this, we asynchronously change white balanche and torch.
The longer term plan is to refactor AVVideoCaptureSource in
https://bugs.webkit.org/show_bug.cgi?id=277088, to do one
beginConfiguration/lock/unlock/commitConfiguration per applyConstraints call.
We make sure to call startApplyingConstraints/endApplyingConstraints whenever
calling updateTorch and updateWhiteBalanceMode.
Manually tested.
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::settingsDidChange):
(WebCore::AVVideoCaptureSource::setFrameRateAndZoomWithPreset):
Canonical link: https://commits.webkit.org/281410@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
