Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1dd5907b5b49891a45360c515de06fa4f2338437
https://github.com/WebKit/WebKit/commit/1dd5907b5b49891a45360c515de06fa4f2338437
Author: Tim Nguyen <[email protected]>
Date: 2024-07-26 (Fri, 26 Jul 2024)
Changed paths:
A LayoutTests/fast/css/quotes-with-text-shadow-expected.html
A LayoutTests/fast/css/quotes-with-text-shadow.html
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/SVGRenderStyle.cpp
M Source/WebCore/rendering/style/StyleInheritedData.cpp
M Source/WebCore/rendering/style/StyleNonInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
Log Message:
-----------
[CSS Quotes] Some CSS properties cause quotes to be reset
https://bugs.webkit.org/show_bug.cgi?id=277154
rdar://132585704
Reviewed by Simon Fraser.
Some RenderStyle setters trigger copy-on-write, so the copy constructors need
to be accurate.
In this case, quotes were not being copied over.
To avoid future similar issues, add ASSERTs to the copy constructors for
classes that RenderStyle directly refers too.
* LayoutTests/fast/css/quotes-with-text-shadow-expected.html: Added.
* LayoutTests/fast/css/quotes-with-text-shadow.html: Added.
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setQuotes): Use arePointingToEqualData as it's easier to
read and equivalent.
* Source/WebCore/rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::SVGRenderStyle):
* Source/WebCore/rendering/style/StyleInheritedData.cpp:
(WebCore::StyleInheritedData::StyleInheritedData):
* Source/WebCore/rendering/style/StyleNonInheritedData.cpp:
(WebCore::StyleNonInheritedData::StyleNonInheritedData):
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
Canonical link: https://commits.webkit.org/281444@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
