Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 71497bb68971edc99d329d88b6bc8aa4dbb2fbec
https://github.com/WebKit/WebKit/commit/71497bb68971edc99d329d88b6bc8aa4dbb2fbec
Author: Tim Nguyen <[email protected]>
Date: 2024-07-27 (Sat, 27 Jul 2024)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/fast/inline/text-overline-underline-position-simple-expected.html
M LayoutTests/fast/inline/text-underline-position-right-simple-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-underline-position-vertical-ja.html
M Source/WebCore/style/InlineTextBoxStyle.cpp
Log Message:
-----------
css/css-text-decor/text-underline-position-vertical* WPT fail
https://bugs.webkit.org/show_bug.cgi?id=203529
rdar://132384098
Reviewed by Alan Baradlay.
The tests expect the default gap (instead of 0) to be applied to the overline,
similarly as it is to the underline.
They check that an overline on the flipped side renders at the same offset than
an non-flipped underline.
Apply the default gap to the overline to make these tests pass.
* LayoutTests/TestExpectations:
* LayoutTests/fast/inline/text-overline-underline-position-simple-expected.html:
* LayoutTests/fast/inline/text-underline-position-right-simple-expected.html:
The new expectations account for this change, the rendering is now more similar
to Chrome & Firefox.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-underline-position-vertical-ja.html:
Avoid flaky paragraph difference by adding a lang=en to the test description
(irrelevant to the test itself).
* Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::overlineOffsetForTextBoxPainting):
Canonical link: https://commits.webkit.org/281456@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
