Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a0ee10281281011863adade244a37ff6dc0da272
https://github.com/WebKit/WebKit/commit/a0ee10281281011863adade244a37ff6dc0da272
Author: Ari Young <[email protected]>
Date: 2024-07-30 (Tue, 30 Jul 2024)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionPermission.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionPermissionPrivate.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPISidebar.mm
Log Message:
-----------
Add conditions for sidebarAction / sidePanel to
WebExtensionAPINamespace::isPropertyAllowed.
https://webkit.org/b/277298
rdar://132763372
Reviewed by Timothy Hatcher and Brian Weinstein.
This patch adds the correct conditions for sidebarAction and sidePanel
to WebExtensionAPINamespace::isPropertyAllowed. It also adds the
sidePanel permission to the list of recognized valid permissions, so
that we can correctly parse it from the manifest. Finally, it also adds
a set of unit tests that exercise the added conditions for property
visibility.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionPermission.h: Declare
_WKWebExtensionPermissionSidePanel
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionPermission.mm: Define
_WKWebExtensionPermissionSidePanel
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::supportedPermissions): Add
_WKWebExtensionPermissionSidePanel to the list of supported permissions.
*
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm:
(WebKit::WebExtensionAPINamespace::isPropertyAllowed): Add correct
conditions for sidePanel / sidebarAction properties
* Tools/TestWebKitAPI/SourcesCocoa.txt: Add WKWebExtensionAPISidebar.mm
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
WKWebExtensionAPISidebar.mm
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPISidebar.mm: Added.
(TestWebKitAPI::WKWebExtensionAPISidebarTest::WKWebExtensionAPISidebarTest):
Add test fixture for sidebar tests
(TestWebKitAPI::TEST_F): Add various tests exercising property
conditions / argument count validation.
Canonical link: https://commits.webkit.org/281585@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
