Title: [111171] trunk/Source/WebCore
Revision
111171
Author
[email protected]
Date
2012-03-19 03:34:29 -0700 (Mon, 19 Mar 2012)

Log Message

Add a copy constructor to CollapsedBorderValue
https://bugs.webkit.org/show_bug.cgi?id=81502

Reviewed by Hajime Morita.

Due to the lack of this copy constructor, GCC (x86) creates a broken copy
constructor and it causes a build break on Google Chrome.

* rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(CollapsedBorderValue):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (111170 => 111171)


--- trunk/Source/WebCore/ChangeLog	2012-03-19 09:56:48 UTC (rev 111170)
+++ trunk/Source/WebCore/ChangeLog	2012-03-19 10:34:29 UTC (rev 111171)
@@ -1,3 +1,17 @@
+2012-03-19  Hironori Bono  <[email protected]>
+
+        Add a copy constructor to CollapsedBorderValue
+        https://bugs.webkit.org/show_bug.cgi?id=81502
+
+        Reviewed by Hajime Morita.
+
+        Due to the lack of this copy constructor, GCC (x86) creates a broken copy
+        constructor and it causes a build break on Google Chrome.
+
+        * rendering/style/CollapsedBorderValue.h:
+        (WebCore::CollapsedBorderValue::CollapsedBorderValue):
+        (CollapsedBorderValue):
+
 2012-03-18  Matt Falkenhagen  <[email protected]>
 
         Fallback to common script when per-script font setting is the empty string

Modified: trunk/Source/WebCore/rendering/style/CollapsedBorderValue.h (111170 => 111171)


--- trunk/Source/WebCore/rendering/style/CollapsedBorderValue.h	2012-03-19 09:56:48 UTC (rev 111170)
+++ trunk/Source/WebCore/rendering/style/CollapsedBorderValue.h	2012-03-19 10:34:29 UTC (rev 111171)
@@ -36,6 +36,15 @@
     {
     }
 
+    // This copy constructor is for preventing GCC (x86) from creating an
+    // unexpected one as written in <http://webkit.org/b/81502>.
+    CollapsedBorderValue(const CollapsedBorderValue& other)
+        : m_border(other.m_border)
+        , m_borderColor(other.m_borderColor)
+        , m_precedence(other.m_precedence)
+    {
+    }
+
     CollapsedBorderValue(const BorderValue& b, Color c, EBorderPrecedence p)
         : m_border(b)
         , m_borderColor(c)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to