Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d9d9b7200189cbcf56cd043089e2ec6a7ac93fd
      
https://github.com/WebKit/WebKit/commit/0d9d9b7200189cbcf56cd043089e2ec6a7ac93fd
  Author: Matt Woodrow <[email protected]>
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
    A 
LayoutTests/compositing/visibility/omitted-hidden-layers-crash-expected.txt
    A LayoutTests/compositing/visibility/omitted-hidden-layers-crash.html
    A 
LayoutTests/compositing/visibility/omitted-hidden-layers-inserted-expected.html
    A LayoutTests/compositing/visibility/omitted-hidden-layers-inserted.html
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayer.h

  Log Message:
  -----------
  REGRESSION (280917@main): Crash when omitting a visibility:hidden RenderLayer 
from the z-order tree.
https://bugs.webkit.org/show_bug.cgi?id=277115
<rdar://132358145>

Reviewed by Simon Fraser.

If we decide we can newly omit a RenderLayer in the z-order tree due to not
being visible, we need to also notify the compositor that these layers are
'gone' so that state can be updated correctly.

* LayoutTests/compositing/visibility/omitted-hidden-layers-crash-expected.txt: 
Added.
* LayoutTests/compositing/visibility/omitted-hidden-layers-crash.html: Added.
* 
LayoutTests/compositing/visibility/omitted-hidden-layers-inserted-expected.html:
 Added.
* LayoutTests/compositing/visibility/omitted-hidden-layers-inserted.html: Added.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateNormalFlowList):
(WebCore::RenderLayer::removeSelfAndDescendantsFromCompositor):
(WebCore::RenderLayer::setWasOmittedFromZOrderTree):
(WebCore::RenderLayer::collectLayers):
(WebCore::RenderLayer::updateLayerListsIfNeeded):
(WebCore::RenderLayer::updateDescendantDependentFlags):
* Source/WebCore/rendering/RenderLayer.h:

Canonical link: https://commits.webkit.org/281636@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to