Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a829f44a065e3bab573c8356f6e64e0f75895f37
      
https://github.com/WebKit/WebKit/commit/a829f44a065e3bab573c8356f6e64e0f75895f37
  Author: Brandon Stewart <[email protected]>
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007-ref.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007.html
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  -----------
  [masonry] Fix intrinsic sizing with fixed-size and auto
https://bugs.webkit.org/show_bug.cgi?id=277382
rdar://problem/132849745

Reviewed by Sammy Gill.

We were not calculating auto sizes when there is a span and it
went outside of the track sizing range. This is due to masonry
trying to place all the indefinite items in each track, and since the span would
be outside the track range it would be skipped.

The solution is to try to shift the item's start and end to fit within the 
track.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007.html:
 Added.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::shouldExcludeGridItemForMasonryTrackSizing 
const):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/281677@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to