Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20780c1b3ad229ddd62aea26af9b877e1b72421e
      
https://github.com/WebKit/WebKit/commit/20780c1b3ad229ddd62aea26af9b877e1b72421e
  Author: Ada Chan <[email protected]>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
    M Source/WebCore/Modules/model-element/HTMLModelElement.h
    M Source/WebCore/Modules/model-element/HTMLModelElement.idl
    M Source/WebCore/Modules/model-element/ModelPlayerClient.h
    M Source/WebCore/dom/DOMPointReadOnly.h
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in

  Log Message:
  -----------
  Expose model bounding box to JS
https://bugs.webkit.org/show_bug.cgi?id=277433
rdar://125586529

Reviewed by Mike Wyrzykowski.

Add two new data members m_boundingBoxCenter and m_boundingBoxExtents
to HTMLModelElement that tracks the center and extents of the loaded model.

When the model process finishes loading the model source, it will send
the model's center and extents info in the DidFinishLoading message.
ModelProcessModelPlayer then calls ModelPlayerClient::didUpdateBoundingBox()
to pass that info along to the model element.

* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::m_boundingBoxExtents):
(WebCore::HTMLModelElement::setSourceURL):
(WebCore::HTMLModelElement::createModelPlayer):
(WebCore::HTMLModelElement::boundingBoxCenter const):
(WebCore::HTMLModelElement::boundingBoxExtents const):
(WebCore::HTMLModelElement::didUpdateBoundingBox):
* Source/WebCore/Modules/model-element/HTMLModelElement.h:
* Source/WebCore/Modules/model-element/HTMLModelElement.idl:
* Source/WebCore/Modules/model-element/ModelPlayerClient.h:
* Source/WebCore/dom/DOMPointReadOnly.h:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::ModelProcessModelPlayerProxy::didFinishLoading):
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp:
(WebKit::ModelProcessModelPlayer::didFinishLoading):
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h:
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in:

Canonical link: https://commits.webkit.org/281722@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to