Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 743aecc8bcfee0db00fd09778a5becc4cf46d53a
https://github.com/WebKit/WebKit/commit/743aecc8bcfee0db00fd09778a5becc4cf46d53a
Author: Matthew Finkel <[email protected]>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebKit/UIProcess/BrowsingWarning.h
M Source/WebKit/UIProcess/Cocoa/BrowsingWarningCocoa.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
Log Message:
-----------
[cocoa] Begin adding https navigation failure browsing warning
https://bugs.webkit.org/show_bug.cgi?id=277527
rdar://problem/133035983
Reviewed by Alex Christensen.
Add two new types that identify the desired warning. Currently the supported
warnings are for SafeBrowsing and HTTPSNavigationFailure.
HTTPSNavigationFailure is the warning associated with the
https-by-default/HTTPSOnly load failure.
The current HTTPSNavigationFailure warning uses the same buttons, color, and
image as the SafeBrowsing warning. These will be changed in subsequent patches.
The SafeBrowsing warning is covered by existing tests. The
HTTPSNavigationFailure warning will be covered by tests in a later patch.
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView
_showWarningViewWithURL:title:warning:detailsWithLinks:completionHandler:]):
* Source/WebKit/UIProcess/BrowsingWarning.h:
(WebKit::BrowsingWarning::create):
(WebKit::BrowsingWarning::type const):
* Source/WebKit/UIProcess/Cocoa/BrowsingWarningCocoa.mm:
(WebKit::browsingWarningTitleText):
(WebKit::browsingWarningText):
(WebKit::browsingDetailsText):
(WebKit::BrowsingWarning::BrowsingWarning):
(WebKit::browsingTitleText): Deleted.
* Source/WebKit/UIProcess/Cocoa/_WKWarningView.mm:
(backgroundColorForWarningType):
(-[_WKWarningView initWithFrame:browsingWarning:completionHandler:]):
Canonical link: https://commits.webkit.org/281773@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
