Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 20b1ec0bfbe1e52d668ae9542715162d0e032b4c
https://github.com/WebKit/WebKit/commit/20b1ec0bfbe1e52d668ae9542715162d0e032b4c
Author: Fujii Hironori <[email protected]>
Date: 2024-08-04 (Sun, 04 Aug 2024)
Changed paths:
M Tools/WebKitTestRunner/win/TestControllerWin.cpp
M Tools/WebKitTestRunner/win/WebKitTestRunnerWS.cpp
Log Message:
-----------
[Win WebKitTestRunner] Fails to capture a crash log if the crash happens
before SetUnhandledExceptionFilter
https://bugs.webkit.org/show_bug.cgi?id=277614
Reviewed by Ross Kirsling.
After https://commits.webkit.org/280706@main introduced
WebKitTestRunnerWS.exe spawning WebKitTestRunner.exe process,
run-webkit-tests scripts failed to capture a crash log of a child
WebKitTestRunner.exe process if the crash happened before calling
SetUnhandledExceptionFilter. For example, crashes in JSC::initialize()
and WebKit::InitializeWebKit2() were not captured.
Instead of using SetUnhandledExceptionFilter in WebKitTestRunner.exe,
output the #CRASH message in WebKitTestRunnerWS.exe.
* Tools/WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitialize):
(WTR::exceptionFilter): Deleted.
* Tools/WebKitTestRunner/win/WebKitTestRunnerWS.cpp:
(wmain):
Canonical link: https://commits.webkit.org/281821@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
