Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 559ec359092079c2bee6b97649eb68cbe7aecb32
https://github.com/WebKit/WebKit/commit/559ec359092079c2bee6b97649eb68cbe7aecb32
Author: Tim Nguyen <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
M LayoutTests/fullscreen/requestFullscreen-escape-key-expected.txt
M LayoutTests/fullscreen/requestFullscreen-escape-key.html
A LayoutTests/fullscreen/webkitRequestFullscreen-escape-key-expected.txt
A LayoutTests/fullscreen/webkitRequestFullscreen-escape-key.html
M Source/WebCore/dom/FullscreenManager.cpp
Log Message:
-----------
[fullscreen] Make "Esc" key check for prefixed & unprefixed APIs consistent
https://bugs.webkit.org/show_bug.cgi?id=276852
rdar://132172599
Reviewed by Andy Estes.
Make this check effective for the unprefixed API as well to be consistent with
other browsers behavior.
The Esc key always worked as exit fullscreen shortcut and can't be overriden
thanks to other checks,
but let's prevent it from being used as shortcut to enter fullscreen.
* LayoutTests/fullscreen/requestFullscreen-escape-key-expected.txt:
* LayoutTests/fullscreen/requestFullscreen-escape-key.html:
* LayoutTests/fullscreen/webkitRequestFullscreen-escape-key-expected.txt:
Copied from LayoutTests/fullscreen/requestFullscreen-escape-key-expected.txt.
* LayoutTests/fullscreen/webkitRequestFullscreen-escape-key.html: Copied from
LayoutTests/fullscreen/requestFullscreen-escape-key.html.
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):
Canonical link: https://commits.webkit.org/281846@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
