Diff
Modified: trunk/Source/WebCore/ChangeLog (111202 => 111203)
--- trunk/Source/WebCore/ChangeLog 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/ChangeLog 2012-03-19 17:46:06 UTC (rev 111203)
@@ -1,3 +1,33 @@
+2012-03-19 Mark Pilgrim <[email protected]>
+
+ Style cleanup in Modules/filesystem/
+ https://bugs.webkit.org/show_bug.cgi?id=81520
+
+ Reviewed by Adam Barth.
+
+ No new tests, all existing tests pass.
+
+ * Modules/filesystem/AsyncFileWriter.h:
+ (WebCore::AsyncFileWriter::~AsyncFileWriter):
+ * Modules/filesystem/AsyncFileWriterClient.h:
+ (WebCore::AsyncFileWriterClient::~AsyncFileWriterClient):
+ * Modules/filesystem/DOMFilePath.cpp:
+ (WebCore::DOMFilePath::getDirectory):
+ * Modules/filesystem/DOMFilePath.h:
+ (DOMFilePath):
+ * Modules/filesystem/DOMFileSystemBase.h:
+ (DOMFileSystemBase):
+ * Modules/filesystem/DirectoryEntry.h:
+ * Modules/filesystem/DirectoryEntrySync.h:
+ * Modules/filesystem/EntryArray.h:
+ (EntryArray):
+ * Modules/filesystem/FileEntry.h:
+ (FileEntry):
+ * Modules/filesystem/FileSystemCallbacks.h:
+ (FileSystemCallbacksBase):
+ * Modules/filesystem/FileWriter.cpp:
+ (WebCore::FileWriter::abort):
+
2012-03-19 Mike Lawther <[email protected]>
CSS3 calc: background positioning works with mixed percent/absolute expressions
Modified: trunk/Source/WebCore/Modules/filesystem/AsyncFileWriter.h (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/AsyncFileWriter.h 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/AsyncFileWriter.h 2012-03-19 17:46:06 UTC (rev 111203)
@@ -42,7 +42,7 @@
class AsyncFileWriter {
public:
- virtual ~AsyncFileWriter() {}
+ virtual ~AsyncFileWriter() { }
virtual void write(long long position, Blob* data) = 0;
virtual void truncate(long long length) = 0;
@@ -58,4 +58,3 @@
#endif // ENABLE(FILE_SYSTEM)
#endif // AsyncFileWriter_h
-
Modified: trunk/Source/WebCore/Modules/filesystem/AsyncFileWriterClient.h (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/AsyncFileWriterClient.h 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/AsyncFileWriterClient.h 2012-03-19 17:46:06 UTC (rev 111203)
@@ -39,7 +39,7 @@
class AsyncFileWriterClient {
public:
- virtual ~AsyncFileWriterClient() {}
+ virtual ~AsyncFileWriterClient() { }
virtual void didWrite(long long bytes, bool complete) = 0;
virtual void didTruncate() = 0;
Modified: trunk/Source/WebCore/Modules/filesystem/DOMFilePath.cpp (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/DOMFilePath.cpp 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/DOMFilePath.cpp 2012-03-19 17:46:06 UTC (rev 111203)
@@ -68,7 +68,7 @@
String DOMFilePath::getDirectory(const String& path)
{
int index = path.reverseFind(DOMFilePath::separator);
- if (index == 0)
+ if (!index)
return DOMFilePath::root;
if (index != -1)
return path.substring(0, index);
Modified: trunk/Source/WebCore/Modules/filesystem/DOMFilePath.h (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/DOMFilePath.h 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/DOMFilePath.h 2012-03-19 17:46:06 UTC (rev 111203)
@@ -70,7 +70,7 @@
return path[path.length() - 1] == DOMFilePath::separator;
}
- // Evaluates all "../" and "./" segments. Note that "/../" expands to "/", so you can't ever refer to anything above the root directory.
+ // Evaluates all "../" and "./" segments. Note that "/../" expands to "/", so you can't ever refer to anything above the root directory.
static String removeExtraParentReferences(const String& path);
// Checks if the given path follows the FileSystem API naming restrictions.
Modified: trunk/Source/WebCore/Modules/filesystem/DOMFileSystemBase.h (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/DOMFileSystemBase.h 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/DOMFileSystemBase.h 2012-03-19 17:46:06 UTC (rev 111203)
@@ -34,8 +34,8 @@
#if ENABLE(FILE_SYSTEM)
#include "AsyncFileSystem.h"
+#include "PlatformString.h"
#include "WebKitFlags.h"
-#include "PlatformString.h"
#include <wtf/PassRefPtr.h>
#include <wtf/RefCounted.h>
@@ -66,8 +66,8 @@
AsyncFileSystem* asyncFileSystem() const { return m_asyncFileSystem.get(); }
SecurityOrigin* securityOrigin() const;
- // Actual FileSystem API implementations. All the validity checks on virtual paths are done at this level.
- // They return false for immediate errors that don't involve lower AsyncFileSystem layer (e.g. for name validation errors). Otherwise they return true (but later may call back with an runtime error).
+ // Actual FileSystem API implementations. All the validity checks on virtual paths are done at this level.
+ // They return false for immediate errors that don't involve lower AsyncFileSystem layer (e.g. for name validation errors). Otherwise they return true (but later may call back with an runtime error).
bool getMetadata(const EntryBase*, PassRefPtr<MetadataCallback>, PassRefPtr<ErrorCallback>);
bool move(const EntryBase* source, EntryBase* parent, const String& name, PassRefPtr<EntryCallback>, PassRefPtr<ErrorCallback>);
bool copy(const EntryBase* source, EntryBase* parent, const String& name, PassRefPtr<EntryCallback>, PassRefPtr<ErrorCallback>);
Modified: trunk/Source/WebCore/Modules/filesystem/DirectoryEntry.h (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/DirectoryEntry.h 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/DirectoryEntry.h 2012-03-19 17:46:06 UTC (rev 111203)
@@ -34,8 +34,8 @@
#if ENABLE(FILE_SYSTEM)
#include "Entry.h"
+#include "PlatformString.h"
#include "WebKitFlags.h"
-#include "PlatformString.h"
#include <wtf/PassRefPtr.h>
#include <wtf/RefCounted.h>
Modified: trunk/Source/WebCore/Modules/filesystem/DirectoryEntrySync.h (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/DirectoryEntrySync.h 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/DirectoryEntrySync.h 2012-03-19 17:46:06 UTC (rev 111203)
@@ -34,8 +34,8 @@
#if ENABLE(FILE_SYSTEM)
#include "EntrySync.h"
+#include "PlatformString.h"
#include "WebKitFlags.h"
-#include "PlatformString.h"
#include <wtf/PassRefPtr.h>
#include <wtf/RefCounted.h>
Modified: trunk/Source/WebCore/Modules/filesystem/EntryArray.h (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/EntryArray.h 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/EntryArray.h 2012-03-19 17:46:06 UTC (rev 111203)
@@ -48,7 +48,7 @@
unsigned length() const { return m_entries.size(); }
Entry* item(unsigned index) const;
- void set(unsigned index, PassRefPtr<Entry> entry);
+ void set(unsigned index, PassRefPtr<Entry>);
bool isEmpty() const { return m_entries.isEmpty(); }
void clear() { m_entries.clear(); }
Modified: trunk/Source/WebCore/Modules/filesystem/FileEntry.h (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/FileEntry.h 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/FileEntry.h 2012-03-19 17:46:06 UTC (rev 111203)
@@ -54,7 +54,7 @@
virtual bool isFile() const { return true; }
private:
- FileEntry(PassRefPtr<DOMFileSystemBase> fileSystem, const String& fullPath);
+ FileEntry(PassRefPtr<DOMFileSystemBase>, const String& fullPath);
};
} // namespace
Modified: trunk/Source/WebCore/Modules/filesystem/FileSystemCallbacks.h (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/FileSystemCallbacks.h 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/FileSystemCallbacks.h 2012-03-19 17:46:06 UTC (rev 111203)
@@ -65,7 +65,7 @@
// Other callback methods are implemented by each subclass.
protected:
- FileSystemCallbacksBase(PassRefPtr<ErrorCallback> errorCallback);
+ FileSystemCallbacksBase(PassRefPtr<ErrorCallback>);
RefPtr<ErrorCallback> m_errorCallback;
};
Modified: trunk/Source/WebCore/Modules/filesystem/FileWriter.cpp (111202 => 111203)
--- trunk/Source/WebCore/Modules/filesystem/FileWriter.cpp 2012-03-19 17:37:18 UTC (rev 111202)
+++ trunk/Source/WebCore/Modules/filesystem/FileWriter.cpp 2012-03-19 17:46:06 UTC (rev 111203)
@@ -168,9 +168,8 @@
void FileWriter::abort(ExceptionCode& ec)
{
ASSERT(writer());
- if (m_readyState != WRITING) {
+ if (m_readyState != WRITING)
return;
- }
++m_numAborts;
if (m_isOperationInProgress)
