Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d9fadec5e2d75447f5cf247746a5d019b9a127f6
https://github.com/WebKit/WebKit/commit/d9fadec5e2d75447f5cf247746a5d019b9a127f6
Author: Wenson Hsieh <[email protected]>
Date: 2024-08-11 (Sun, 11 Aug 2024)
Changed paths:
M Source/WebCore/page/ElementTargetingController.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm
Log Message:
-----------
Element targeting via search text should resolve to elements with existing
visibility adjustment
https://bugs.webkit.org/show_bug.cgi?id=277932
rdar://131716603
Reviewed by Abrar Rahman Protyasha.
Adjust element targeting codepaths such that targeted element requests that are
based on search
text can resolve to elements that are inside of hidden subtrees (i.e.
visibility adjustment).
* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::ClearVisibilityAdjustmentForScope::ClearVisibilityAdjustmentForScope):
Implement a move constructor so that I can construct a `Vector<>` of scopes
below.
(WebCore::ClearVisibilityAdjustmentForScope::~ClearVisibilityAdjustmentForScope):
Pull this class up to the top of the file, so that we can use it in
`findTargets` as well.
(WebCore::shouldIgnoreExistingVisibilityAdjustments):
(WebCore::ElementTargetingController::findTargets):
See above for more details.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm:
(TestWebKitAPI::TEST(ElementTargeting,
RequestTargetedElementsBySearchableText)):
Augment an existing API test to exercise the change.
Canonical link: https://commits.webkit.org/282109@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
