Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d59f182d669baa4fb54eda546e9f76aa9d29ed82
https://github.com/WebKit/WebKit/commit/d59f182d669baa4fb54eda546e9f76aa9d29ed82
Author: Eddie Kohler <[email protected]>
Date: 2024-08-12 (Mon, 12 Aug 2024)
Changed paths:
A LayoutTests/fast/table/row-background-image-expected.html
A LayoutTests/fast/table/row-background-image.html
M Source/WebCore/rendering/RenderTableCell.cpp
M Source/WebCore/rendering/RenderTableCell.h
M Source/WebCore/rendering/RenderTableRow.cpp
M Source/WebCore/rendering/RenderTableSection.cpp
Log Message:
-----------
Fix background-images on table rows and sections
https://bugs.webkit.org/show_bug.cgi?id=9268
Reviewed by Alan Baradlay
In tables, background-images applied to table rows, columns, column
groups, and row groups (sections) should span the whole relevant area.
For instance, a gradient applied to a table row should span smoothly
across the cells. This is the behavior on Firefox and Chrome, but on
Safari, the image was applied to each cell separately, resulting in
multiple distinct gradients. This commit fixes that for rows and
sections, by rendering the image with the correct dimensions, but
clipped to the relevant cells.
* LayoutTests/fast/table/row-background-image-expected.html: Added.
* LayoutTests/fast/table/row-background-image.html: Added.
* Source/WebCore/rendering/RenderTableCell.cpp:
* Source/WebCore/rendering/RenderTableCell.h:
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
Add support for correct row and section background rendering.
Change paintBackgroundsBehindCell signature to take the position
relevant to the background object.
* Source/WebCore/rendering/RenderTableRow.cpp:
* Source/WebCore/rendering/RenderTableSection.cpp:
Pass new argument to paintBackgroundsBehindCell.
Canonical link: https://commits.webkit.org/282122@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
