Title: [111233] trunk
- Revision
- 111233
- Author
- [email protected]
- Date
- 2012-03-19 13:29:41 -0700 (Mon, 19 Mar 2012)
Log Message
platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81530
Reviewed by Jessie Berlin.
Tools:
Add rowAtIndex to WebKitTestRunner.
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::rowAtIndex):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR):
(WTR::AccessibilityUIElement::rowAtIndex):
LayoutTests:
* platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (111232 => 111233)
--- trunk/LayoutTests/ChangeLog 2012-03-19 20:28:39 UTC (rev 111232)
+++ trunk/LayoutTests/ChangeLog 2012-03-19 20:29:41 UTC (rev 111233)
@@ -1,3 +1,12 @@
+2012-03-19 Chris Fleizach <[email protected]>
+
+ platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
+ https://bugs.webkit.org/show_bug.cgi?id=81530
+
+ Reviewed by Jessie Berlin.
+
+ * platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Removed.
+
2012-03-19 Jessie Berlin <[email protected]>
editing/input/reveal-edit-on-input-vertically.html and
Deleted: trunk/LayoutTests/platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt (111232 => 111233)
--- trunk/LayoutTests/platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt 2012-03-19 20:28:39 UTC (rev 111232)
+++ trunk/LayoutTests/platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt 2012-03-19 20:29:41 UTC (rev 111233)
@@ -1,20 +0,0 @@
-a
-
-
-b
-
-
-c
-This tests that the selected rows of a table are exposed correctly and that when they change, a notification is sent.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS addedNotification is true
-FAIL axTree.selectedRowAtIndex(0).isEqual(axTree.rowAtIndex(0)) should be true. Threw exception TypeError: 'undefined' is not a function (evaluating 'axTree.rowAtIndex(0)')
-FAIL axTree.selectedRowAtIndex(1).isEqual(axTree.rowAtIndex(2)) should be true. Threw exception TypeError: 'undefined' is not a function (evaluating 'axTree.rowAtIndex(2)')
-PASS successfullyParsed is true
-
-TEST COMPLETE
-Notification: AXSelectedRowsChanged
-
Modified: trunk/Tools/ChangeLog (111232 => 111233)
--- trunk/Tools/ChangeLog 2012-03-19 20:28:39 UTC (rev 111232)
+++ trunk/Tools/ChangeLog 2012-03-19 20:29:41 UTC (rev 111233)
@@ -1,3 +1,21 @@
+2012-03-19 Chris Fleizach <[email protected]>
+
+ platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
+ https://bugs.webkit.org/show_bug.cgi?id=81530
+
+ Reviewed by Jessie Berlin.
+
+ Add rowAtIndex to WebKitTestRunner.
+
+ * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
+ (WTR::AccessibilityUIElement::rowAtIndex):
+ * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
+ (AccessibilityUIElement):
+ * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
+ * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+ (WTR):
+ (WTR::AccessibilityUIElement::rowAtIndex):
+
2012-03-19 Ojan Vafai <[email protected]>
Change garden-o-matic All Failures tab to Expected Failures
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp (111232 => 111233)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp 2012-03-19 20:28:39 UTC (rev 111232)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp 2012-03-19 20:29:41 UTC (rev 111233)
@@ -144,6 +144,7 @@
PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::selectedRowAtIndex(unsigned) { return 0; }
PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::disclosedByRow() { return 0; }
PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::disclosedRowAtIndex(unsigned) { return 0; }
+PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::rowAtIndex(unsigned) { return 0; }
PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::ariaOwnsElementAtIndex(unsigned) { return 0; }
PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::ariaFlowToElementAtIndex(unsigned) { return 0; }
bool AccessibilityUIElement::ariaIsGrabbed() const { return false; }
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h (111232 => 111233)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h 2012-03-19 20:28:39 UTC (rev 111232)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h 2012-03-19 20:29:41 UTC (rev 111233)
@@ -180,6 +180,7 @@
PassRefPtr<AccessibilityUIElement> selectedRowAtIndex(unsigned);
PassRefPtr<AccessibilityUIElement> disclosedByRow();
PassRefPtr<AccessibilityUIElement> disclosedRowAtIndex(unsigned);
+ PassRefPtr<AccessibilityUIElement> rowAtIndex(unsigned);
// ARIA specific
PassRefPtr<AccessibilityUIElement> ariaOwnsElementAtIndex(unsigned);
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl (111232 => 111233)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl 2012-03-19 20:28:39 UTC (rev 111232)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl 2012-03-19 20:29:41 UTC (rev 111233)
@@ -118,6 +118,7 @@
AccessibilityUIElement selectedRowAtIndex(in unsigned long index);
AccessibilityUIElement disclosedByRow();
AccessibilityUIElement disclosedRowAtIndex(in unsigned long index);
+ AccessibilityUIElement rowAtIndex(in unsigned long index);
int indexInTable();
DOMString rowIndexRange();
DOMString columnIndexRange();
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm (111232 => 111233)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2012-03-19 20:28:39 UTC (rev 111232)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2012-03-19 20:29:41 UTC (rev 111233)
@@ -326,6 +326,17 @@
return 0;
}
+
+PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::rowAtIndex(unsigned index)
+{
+ BEGIN_AX_OBJC_EXCEPTIONS
+ NSArray* rows = [m_element accessibilityAttributeValue:NSAccessibilityRowsAttribute];
+ if (index < [rows count])
+ return AccessibilityUIElement::create([rows objectAtIndex:index]);
+ END_AX_OBJC_EXCEPTIONS
+
+ return 0;
+}
PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::selectedChildAtIndex(unsigned index) const
{
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
