Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44c9bb0d8bbf805cf848e72ea793230b5694aacb https://github.com/WebKit/WebKit/commit/44c9bb0d8bbf805cf848e72ea793230b5694aacb Author: Abrar Rahman Protyasha <a_protya...@apple.com> Date: 2024-08-13 (Tue, 13 Aug 2024)
Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm Log Message: ----------- [Cocoa] PDFPluginBase::dictionaryPopupInfoForSelection() should not be a no-op on iOS family https://bugs.webkit.org/show_bug.cgi?id=278012 rdar://133745817 Reviewed by Aditya Keerthi. Previously, this function was a no-op on iOS family platforms because of its use of NSFont(Manager). We can simply use our CocoaFont definition and the -[UIFont fontWithSize:] instance method as suitable alternatives to make this function cross platform. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::dictionaryPopupInfoForSelection): Canonical link: https://commits.webkit.org/282186@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes