Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 446379687a696e1302ef66f18079c77bad2f0fe0
https://github.com/WebKit/WebKit/commit/446379687a696e1302ef66f18079c77bad2f0fe0
Author: David Kilzer <[email protected]>
Date: 2024-08-17 (Sat, 17 Aug 2024)
Changed paths:
M Source/JavaScriptCore/inspector/remote/RemoteInspector.cpp
M Source/JavaScriptCore/inspector/remote/RemoteInspector.h
M Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm
Log Message:
-----------
Build fix: Move Inspector::RemoteInspector destructor to source file for
upstream clang
<https://bugs.webkit.org/show_bug.cgi?id=278275>
<rdar://134140254>
Reviewed by Devin Rousso.
In upstream clang, destructors require full class definitions for any
instance variable that is destructed. In most cases, moving the
destructor out of the header will fix this build failure without
increasing header parsing time.
* Source/JavaScriptCore/inspector/remote/RemoteInspector.cpp:
(Inspector::RemoteInspector::~RemoteInspector):
- Move destructor here for non-Apple ports.
* Source/JavaScriptCore/inspector/remote/RemoteInspector.h:
- Declare virtual destructor.
* Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::~RemoteInspector):
- Move destructor here for Apple ports. We must declare the destructor
here because the xpc_object_t parameter in
RemoteInspector::xpcConnectionUnhandledMessage() has a different type
in C++ (void*) vs. Objective-C++ (NSObject<OS_xpc_object>*), which
results in a link error if the destructor is compiled in
RemoteInspector.cpp but xpcConnectionUnhandledMessage() is compiled in
RemoteInspectorCocoa.mm.
Canonical link: https://commits.webkit.org/282391@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
