Title: [111262] trunk/Tools
- Revision
- 111262
- Author
- [email protected]
- Date
- 2012-03-19 15:52:42 -0700 (Mon, 19 Mar 2012)
Log Message
Make the selected item in the accordion a link to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=81571
Reviewed by Dimitri Glazkov.
Also, make it so that you can select the text of the link, instead of the current behavior
of acting as if you had clicked on the accordion header.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (111261 => 111262)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2012-03-19 22:42:53 UTC (rev 111261)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2012-03-19 22:52:42 UTC (rev 111262)
@@ -173,13 +173,18 @@
this._length = 0;
Object.keys(resultsByTest).sort().forEach(function(testName) {
- var link = document.createElement('a');
- $(link).attr('href', '#').text(testName);
+ var nonLinkTitle = document.createElement('a');
+ $(nonLinkTitle).addClass('non-link-title');
+ $(nonLinkTitle).attr('href', "#").text(testName);
+ var linkTitle = document.createElement('a');
+ $(linkTitle).addClass('link-title');
+ $(linkTitle).attr('href', ui.urlForFlakinessDashboard([testName])).text(testName);
+
var header = document.createElement('h3');
$(header).append(new ui.actions.List([
new ui.actions.Rebaseline().makeDefault(),
- ])).append(link);
+ ])).append(nonLinkTitle).append(linkTitle);
this.appendChild(header);
this.appendChild(this._delegate.contentForTest(testName));
++this._length; // There doesn't seem to be any good way to get this information from accordion.
@@ -188,8 +193,15 @@
$(this).accordion({
collapsible: true,
autoHeight: false,
+ event: 'customaccordianclick',
});
$(this).accordion('activate', false);
+
+ // jQuery's builtin accordion overrides mousedown, which means you can't select the header text
+ // or click on the link to the flakiness dashboard.
+ $('.ui-accordion-header').live('click', function() {
+ $(this).trigger('customaccordianclick');
+ })
},
nextResult: function()
{
@@ -236,7 +248,7 @@
currentTestName: function()
{
var currentIndex = $(this).accordion('option', 'active');
- return $('h3 a', this)[currentIndex].textContent;
+ return $('h3 .non-link-title', this)[currentIndex].textContent;
}
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css (111261 => 111262)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css 2012-03-19 22:42:53 UTC (rev 111261)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css 2012-03-19 22:52:42 UTC (rev 111262)
@@ -78,3 +78,14 @@
width: 100%;
height: auto;
}
+
+.ui-state-default .link-title, .ui-state-default .link-title:link, .ui-state-default .link-title:visited {
+ display: none;
+}
+.ui-state-active .link-title, .ui-state-active .link-title:link, .ui-state-active .link-title:visited {
+ text-decoration: underline;
+ display: inline-block;
+}
+.ui-state-active .non-link-title, .ui-state-active .non-link-title:link, .ui-state-active .non-link-title:visited {
+ display: none;
+}
Modified: trunk/Tools/ChangeLog (111261 => 111262)
--- trunk/Tools/ChangeLog 2012-03-19 22:42:53 UTC (rev 111261)
+++ trunk/Tools/ChangeLog 2012-03-19 22:52:42 UTC (rev 111262)
@@ -1,3 +1,16 @@
+2012-03-19 Ojan Vafai <[email protected]>
+
+ Make the selected item in the accordion a link to the flakiness dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=81571
+
+ Reviewed by Dimitri Glazkov.
+
+ Also, make it so that you can select the text of the link, instead of the current behavior
+ of acting as if you had clicked on the accordion header.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
+
2012-03-19 Dirk Pranke <[email protected]>
NRWT runs some tests that are skipped with -i command line option
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
