Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9a0cd9a20789d917b44fa41133a5a2f1a4a5bea6
https://github.com/WebKit/WebKit/commit/9a0cd9a20789d917b44fa41133a5a2f1a4a5bea6
Author: Rob Buis <[email protected]>
Date: 2024-08-19 (Mon, 19 Aug 2024)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/current-basic-expected.txt
M Source/WebCore/page/NavigationHistoryEntry.cpp
M Source/WebCore/page/NavigationHistoryEntry.h
Log Message:
-----------
[Navigation] Fix navigation-history-entry/current-basic.html
https://bugs.webkit.org/show_bug.cgi?id=278294
Reviewed by Alex Christensen.
Right now we use the HistoryItem to obtain the url string. However, same
document
navigations change the current HistoryItem, so the NavigationHistoryEntry
before and
after the same document navigation would share the same HistoryItem reference
and thus
the same url string. To fix this, make NavigationHistoryEntry have its own url
string
copy on NavigationHistoryEntry creation.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/current-basic-expected.txt:
* Source/WebCore/page/NavigationHistoryEntry.cpp:
(WebCore::NavigationHistoryEntry::NavigationHistoryEntry):
(WebCore::NavigationHistoryEntry::url const):
* Source/WebCore/page/NavigationHistoryEntry.h:
Canonical link: https://commits.webkit.org/282458@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
