Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ba3e2658de9289485203a58829140f7ae0193a48
https://github.com/WebKit/WebKit/commit/ba3e2658de9289485203a58829140f7ae0193a48
Author: Anne van Kesteren <[email protected]>
Date: 2024-08-19 (Mon, 19 Aug 2024)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebCore/bindings/js/WebCoreBuiltinNames.h
M Source/WebCore/dom/GlobalEventHandlers.idl
M Source/WebCore/html/HTMLAttributeNames.in
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/HTMLInputElement.h
M Source/WebCore/html/HTMLInputElement.idl
M Source/WebCore/html/SearchInputType.cpp
M Source/WebCore/html/SearchInputType.h
M Source/WebCore/html/shadow/TextControlInnerElements.cpp
M Source/WebCore/rendering/RenderSearchField.cpp
M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
M Source/WebKit/Shared/WebPreferencesDefaultValues.h
M Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm
M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h
M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm
Log Message:
-----------
Remove incremental attribute and search event code
https://bugs.webkit.org/show_bug.cgi?id=278309
Reviewed by Aditya Keerthi.
In 266068@main we put these features behind a flag with the intention
of keeping them enabled in embedded applications. However, as we did
not do that correctly they ended up disabled everywhere. Fortunately,
no reports of breakage came in.
Now that even more time has passed, it seems reasonable to remove all
applicable code.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/dom/GlobalEventHandlers.idl:
* Source/WebCore/html/HTMLAttributeNames.in:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attributeChanged):
(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::onSearch): Deleted.
* Source/WebCore/html/HTMLInputElement.h:
* Source/WebCore/html/HTMLInputElement.idl:
* Source/WebCore/html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::handleKeydownEvent):
(WebCore::SearchInputType::didSetValueByUserEdit):
(WebCore::SearchInputType::startSearchEventTimer): Deleted.
(WebCore::SearchInputType::stopSearchEventTimer): Deleted.
(WebCore::SearchInputType::searchEventTimerFired): Deleted.
(WebCore::SearchInputType::searchEventsShouldBeDispatched const): Deleted.
* Source/WebCore/html/SearchInputType.h:
* Source/WebCore/html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
* Source/WebCore/rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::valueChanged):
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultSearchInputIncrementalAttributeAndSearchEventEnabled): Deleted.
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:
* Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:
(-[DOMHTMLInputElement incremental]):
(-[DOMHTMLInputElement setIncremental:]):
* Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h:
* Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:
(WebKit::defaultSearchInputIncrementalAttributeAndSearchEventEnabled): Deleted.
Canonical link: https://commits.webkit.org/282483@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
