Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4c0d1d609b41524f449e15c28ce223cdfb57bdab
https://github.com/WebKit/WebKit/commit/4c0d1d609b41524f449e15c28ce223cdfb57bdab
Author: Richard Robinson <[email protected]>
Date: 2024-08-23 (Fri, 23 Aug 2024)
Changed paths:
M Source/WebCore/page/writing-tools/WritingToolsController.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm
Log Message:
-----------
[Writing Tools] Selection sometimes may not show up when a session's
animations finish
https://bugs.webkit.org/show_bug.cgi?id=278532
rdar://134516446
Reviewed by Abrar Rahman Protyasha.
There is currently a race condition between when the replace animation ends and
when the replacement
is complete which causes `showSelectionForActiveWritingToolsSession` to not
properly reveal the selection.
Fix by always checking the condition in
`_didEndPartialIntelligenceTextPonderingAnimation` instead.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didEndPartialIntelligenceTextPonderingAnimation]):
(-[WKWebView _intelligenceTextPonderingAnimationIsComplete]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::showSelectionForActiveWritingToolsSession):
(WebKit::WebPageProxy::showSelectionForActiveWritingToolsSessionIfNeeded):
Deleted.
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView replacementEffectDidComplete]):
* Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm:
(-[WKTextAnimationManager addTextAnimationForAnimationID:withData:]):
Canonical link: https://commits.webkit.org/282666@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
