Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a253e130f3044813272fb539081ca53fee7bbf84
https://github.com/WebKit/WebKit/commit/a253e130f3044813272fb539081ca53fee7bbf84
Author: Ben Nham <[email protected]>
Date: 2024-08-27 (Tue, 27 Aug 2024)
Changed paths:
M Source/WTF/wtf/SystemTracing.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
Fix build break from 282779@main
https://bugs.webkit.org/show_bug.cgi?id=278732
rdar://134784868
Reviewed by Wenson Hsieh.
282779@main broke the Cocoa build. We did not catch this on the bots because
SystemTracing.h
conditionalized calls to `os_signpost` based on `HAVE(KDEBUG_H)` rather than
`HAVE(OS_SIGNPOST)`.
Fixed these issues:
1. All signpost names passed to WTF signpost macros on Cocoa must also be part
of the
FOR_EACH_WTF_SIGNPOST_NAME list in the header. 282779@main added the
FinalizeRenderingUpdate
signpost on Cocoa, but it wasn't part of the header.
2. Always build the os_signpost code on Cocoa so we catch build breaks like
this in the future.
3. Simon says he doesn't want the FinalizeRenderingUpdate signpost on Cocoa, so
conditionalize that
call.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::finalizeRenderingUpdate):
Canonical link: https://commits.webkit.org/282803@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
