Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7d7765892bff21fb526e4b04fcc1a56a7d6def63
https://github.com/WebKit/WebKit/commit/7d7765892bff21fb526e4b04fcc1a56a7d6def63
Author: Andy Estes <aes...@apple.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)
Changed paths:
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/model.py
M Source/WebKit/Scripts/webkit/parser.py
M Source/WebKit/Scripts/webkit/tests/Makefile
M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
M Source/WebKit/Scripts/webkit/tests/MessageNames.cpp
M Source/WebKit/Scripts/webkit/tests/MessageNames.h
M Source/WebKit/Scripts/webkit/tests/TestWithEnabledBy.messages.in
A
Source/WebKit/Scripts/webkit/tests/TestWithEnabledByAndConjunction.messages.in
A
Source/WebKit/Scripts/webkit/tests/TestWithEnabledByAndConjunctionMessageReceiver.cpp
A
Source/WebKit/Scripts/webkit/tests/TestWithEnabledByAndConjunctionMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithEnabledByMessageReceiver.cpp
M Source/WebKit/Scripts/webkit/tests/TestWithEnabledByMessages.h
A
Source/WebKit/Scripts/webkit/tests/TestWithEnabledByOrConjunction.messages.in
A
Source/WebKit/Scripts/webkit/tests/TestWithEnabledByOrConjunctionMessageReceiver.cpp
A
Source/WebKit/Scripts/webkit/tests/TestWithEnabledByOrConjunctionMessages.h
Log Message:
-----------
Teach messages.py to handle || conjunctions in EnabledBy attributes
https://bugs.webkit.org/show_bug.cgi?id=278754
rdar://problem/134823689
Reviewed by Ryosuke Niwa.
Taught messages.py to handle || conjunctions in EnabledBy attributes,
e.g. [EnabledBy=SomeSetting || OtherSetting]. This compliments the existing
ability to handle &&
conjunctions and will be used in a future change to how
WebFullScreenManagerProxy will be enabled.
Note that for now we explicitly reject combinations of && and ||.
Added webkitpy tests.
* Source/WebKit/Scripts/webkit/messages.py:
(generate_enabled_by):
Changed to join preferences using the passed-in conjunction.
(generate_runtime_enablement):
Changed to bracket the generated expression with parentheses when there are
multiple preferences.
(generate_enabled_by_for_receiver):
Passed receiver_enabled_by_conjunction to generate_enabled_by().
* Source/WebKit/Scripts/webkit/model.py:
(MessageReceiver.__init__):
(Message.__init__):
Stored the EnabledBy conjunction.
(generate_global_model):
* Source/WebKit/Scripts/webkit/parser.py:
(parse):
(parse_parameters_string):
(parse_enabled_by_string):
Added a helper method to parse the preferences and conjunction from the
EnabledBy string.
* Source/WebKit/Scripts/webkit/tests/Makefile:
* Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp:
* Source/WebKit/Scripts/webkit/tests/MessageNames.cpp:
* Source/WebKit/Scripts/webkit/tests/MessageNames.h:
* Source/WebKit/Scripts/webkit/tests/TestWithEnabledBy.messages.in:
*
Source/WebKit/Scripts/webkit/tests/TestWithEnabledByAndConjunction.messages.in:
Added.
*
Source/WebKit/Scripts/webkit/tests/TestWithEnabledByAndConjunctionMessageReceiver.cpp:
Added.
* Source/WebKit/Scripts/webkit/tests/TestWithEnabledByAndConjunctionMessages.h:
Added.
* Source/WebKit/Scripts/webkit/tests/TestWithEnabledByMessageReceiver.cpp:
* Source/WebKit/Scripts/webkit/tests/TestWithEnabledByMessages.h:
*
Source/WebKit/Scripts/webkit/tests/TestWithEnabledByOrConjunction.messages.in:
Added.
*
Source/WebKit/Scripts/webkit/tests/TestWithEnabledByOrConjunctionMessageReceiver.cpp:
Added.
* Source/WebKit/Scripts/webkit/tests/TestWithEnabledByOrConjunctionMessages.h:
Added.
Canonical link: https://commits.webkit.org/282830@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
