Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6abfe5152e1420ffbcccdd1e4385223d47367a42
https://github.com/WebKit/WebKit/commit/6abfe5152e1420ffbcccdd1e4385223d47367a42
Author: Brian Weinstein <[email protected]>
Date: 2024-08-30 (Fri, 30 Aug 2024)
Changed paths:
M Source/WebKit/Platform/spi/mac/AppKitSPI.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommand.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommandPrivate.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionCommand.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICommands.mm
Log Message:
-----------
Give WKWebExtensionCommand a userVisibleShortcut SPI
https://bugs.webkit.org/show_bug.cgi?id=278948
<rdar://problem/135039103>
Reviewed by Timothy Hatcher.
This method uses AppKit SPI for generating this string for macOS, and builds up
a string representing the keyboard
shortcut on iOS.
* Source/WebKit/Platform/spi/mac/AppKitSPI.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommand.mm:
(-[WKWebExtensionCommand _userVisibleShortcut]): Call into
WebExtensionCommand::userVisibleShortcut.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommandPrivate.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm:
(WebKit::WebExtensionCommand::userVisibleShortcut const): Use SPI on macOS and
build a string on iOS.
* Source/WebKit/UIProcess/Extensions/WebExtensionCommand.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICommands.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPICommands, CommandForEvent)): Test the
_userVisibleShortcut of the
commands given as part of this test.
Canonical link: https://commits.webkit.org/283001@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
