Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd239c6f2e9ee54e77a6ae9293edfaf3a0655fbc
      
https://github.com/WebKit/WebKit/commit/dd239c6f2e9ee54e77a6ae9293edfaf3a0655fbc
  Author: Alan Baradlay <[email protected]>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    A 
LayoutTests/fast/inline/nested-vertical-alignment-with-top-and-line-height-expected.html
    A 
LayoutTests/fast/inline/nested-vertical-alignment-with-top-and-line-height.html
    M 
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp

  Log Message:
  -----------
  [IFC] Incorrect vertical position of nested content with parent of 
'vertical-align: top'
https://bugs.webkit.org/show_bug.cgi?id=279088

Reviewed by Antti Koivisto.

When an inline box is not contentful (e.g. <span>this is contentful</span> 
<span><img></span> <- this is not) we are supposed to ignore its own
layout bounds metrics when computing top position (since it has no content that 
would use such geometry).

* 
LayoutTests/fast/inline/nested-vertical-alignment-with-top-and-line-height-expected.html:
 Added.
* 
LayoutTests/fast/inline/nested-vertical-alignment-with-top-and-line-height.html:
 Added.
* 
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::alignInlineLevelBoxes const):

Canonical link: https://commits.webkit.org/283150@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to