Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3436af9c03b8aabdac79ac9d5978a6187a76c241
https://github.com/WebKit/WebKit/commit/3436af9c03b8aabdac79ac9d5978a6187a76c241
Author: Timothy Hatcher <[email protected]>
Date: 2024-09-06 (Fri, 06 Sep 2024)
Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm
Log Message:
-----------
Turn on ENABLE_WK_WEB_EXTENSIONS_ICON_VARIANTS.
https://webkit.org/b/279271
rdar://problem/135422752
Reviewed by Brian Weinstein.
Also fix some issues that caused tests to fail on iOS, since the feature flag
was off
this wasn't caught on the bots originally.
* Source/WTF/wtf/PlatformEnableCocoa.h: Turn on the
ENABLE_WK_WEB_EXTENSIONS_ICON_VARIANTS
feature flag, gated on ENABLE_WK_WEB_EXTENSIONS.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(WebKit::WebExtensionAction::icon): Don't resize the image if not needed.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::resourceTypeForPath): Use file extension if available.
(WebKit::WebExtension::imageForPath): Return single image directly.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus, MenuItemWithIconVariants)):
Updated.
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus, MenuItemWithImageDataVariants)):
Updated.
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus,
MenuItemWithMixedValidAndInvalidIconVariants)): Updated.
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus,
MenuItemWithAnySizeVariantAndSVGDataURL)): Updated.
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus, UpdateMenuItemWithIconVariants)):
Updated.
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus,
ClearMenuItemIconVariantsWithNull)): Updated.
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus,
ClearMenuItemIconVariantsWithEmpty)): Updated.
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(TestWebKitAPI::Util::pixelColor): Get imageAsset image with current traits.
Canonical link: https://commits.webkit.org/283288@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
