Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4b8ccccbb02824099db9bd948edaa997186cec7d
https://github.com/WebKit/WebKit/commit/4b8ccccbb02824099db9bd948edaa997186cec7d
Author: Timothy Hatcher <[email protected]>
Date: 2024-09-10 (Tue, 10 Sep 2024)
Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionSidebarCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
Log Message:
-----------
File input types does not show open panel in Web Extension on Mac.
https://webkit.org/b/279417
rdar://135651344
Reviewed by Jeff Miller.
Implement the
`webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:`
delegate method on Mac
and use `NSOpenPanel` for an implementation. Hook it up to the background page,
action, and sidebar web views.
This is not trivially testable in an API test due to the UI interaction
required to complete. Tested manually
with a sample extension.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(-[_WKWebExtensionActionWebViewDelegate
webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]): Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(-[_WKWebExtensionContextDelegate
webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]): Added.
(WebKit::WebExtensionContext::runOpenPanel): Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionSidebarCocoa.mm:
(-[_WKWebExtensionSidebarWebViewDelegate
webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]): Added.
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
Canonical link: https://commits.webkit.org/283418@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
