Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 826e5996a267a9dbe9ddc4bf97e329e777460b8a
https://github.com/WebKit/WebKit/commit/826e5996a267a9dbe9ddc4bf97e329e777460b8a
Author: Antti Koivisto <[email protected]>
Date: 2024-09-10 (Tue, 10 Sep 2024)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-cascade-expected.txt
M Source/WebCore/style/RuleFeature.cpp
M Source/WebCore/style/RuleFeature.h
M Source/WebCore/style/StyleResolver.h
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/StyleTreeResolver.h
Log Message:
-----------
[css-transitions] WPT test css/css-transitions/starting-style-cascade.html
has failures
https://bugs.webkit.org/show_bug.cgi?id=276664
rdar://131515890
Reviewed by Sam Weinig.
Inherit after-change style from after-change style of the parent also in case
where the element has no animations.
"Likewise, define the after-change style as... and inheriting from the
after-change style of the parent"
*
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-cascade-expected.txt:
* Source/WebCore/style/RuleFeature.cpp:
(WebCore::Style::RuleFeatureSet::collectFeatures):
(WebCore::Style::RuleFeatureSet::add):
(WebCore::Style::RuleFeatureSet::clear):
* Source/WebCore/style/RuleFeature.h:
Track if we are using @starting-style rules so we don't need to do extra work
of computing after-change styles otherwise.
* Source/WebCore/style/StyleResolver.h:
(WebCore::Style::Resolver::usesStartingStyleRules const):
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
Resolve the after change style if needed and shove it into
lastStyleChangeEventStyle.
(WebCore::Style::TreeResolver::resolveStartingStyle const):
(WebCore::Style::TreeResolver::resolveAfterChangeStyleForNonAnimated const):
Re-resolve style inheriting from parent after change style.
Only compute this if we have @starting-style rules and the parent has
lastStyleChangeEventStyle.
(WebCore::Style::TreeResolver::resolveAgainWithParentStyle const):
Factor into function.
(WebCore::Style::TreeResolver::parentAfterChangeStyle const):
Factor into function.
(WebCore::Style::TreeResolver::popParent):
Clear lastStyleChangeEventStyle after if there are no animations on the element.
It only affects descendant resolution.
* Source/WebCore/style/StyleTreeResolver.h:
Canonical link: https://commits.webkit.org/283423@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes