Title: [111384] trunk
Revision
111384
Author
[email protected]
Date
2012-03-20 05:17:26 -0700 (Tue, 20 Mar 2012)

Log Message

Web Inspector: newly added CSS rules shouldn't rewrite HTML content in the resources panel
https://bugs.webkit.org/show_bug.cgi?id=81414

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):

LayoutTests:

* inspector/styles/styles-add-new-rule.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (111383 => 111384)


--- trunk/LayoutTests/ChangeLog	2012-03-20 12:01:26 UTC (rev 111383)
+++ trunk/LayoutTests/ChangeLog	2012-03-20 12:17:26 UTC (rev 111384)
@@ -1,3 +1,12 @@
+2012-03-20  Alexander Pavlov  <[email protected]>
+
+        Web Inspector: newly added CSS rules shouldn't rewrite HTML content in the resources panel
+        https://bugs.webkit.org/show_bug.cgi?id=81414
+
+        Reviewed by Vsevolod Vlasov.
+
+        * inspector/styles/styles-add-new-rule.html:
+
 2012-03-20  Nikolas Zimmermann  <[email protected]>
 
         Make animVal support type-safe

Modified: trunk/LayoutTests/inspector/styles/styles-add-new-rule.html (111383 => 111384)


--- trunk/LayoutTests/inspector/styles/styles-add-new-rule.html	2012-03-20 12:01:26 UTC (rev 111383)
+++ trunk/LayoutTests/inspector/styles/styles-add-new-rule.html	2012-03-20 12:17:26 UTC (rev 111384)
@@ -8,8 +8,10 @@
 {
     WebInspector.showPanel("elements");
     InspectorTest.selectNodeAndWaitForStyles("inspected", step1);
+    InspectorTest.addSniffer(WebInspector.Resource.prototype, "addRevision", revisionAdded);
 
     var treeElement;
+    var hasResourceChanged;
 
     function step1()
     {
@@ -50,8 +52,15 @@
     {
         InspectorTest.addResult("After adding new rule (other):");
         InspectorTest.dumpSelectedElementStyles(true, false, true);
+        if (hasResourceChanged)
+            InspectorTest.addResult("Error: main resource content changed");
         InspectorTest.completeTest();
     }
+
+    function revisionAdded()
+    {
+        hasResourceChanged = true;
+    }
 }
 
 </script>

Modified: trunk/Source/WebCore/ChangeLog (111383 => 111384)


--- trunk/Source/WebCore/ChangeLog	2012-03-20 12:01:26 UTC (rev 111383)
+++ trunk/Source/WebCore/ChangeLog	2012-03-20 12:17:26 UTC (rev 111384)
@@ -1,3 +1,14 @@
+2012-03-20  Alexander Pavlov  <[email protected]>
+
+        Web Inspector: newly added CSS rules shouldn't rewrite HTML content in the resources panel
+        https://bugs.webkit.org/show_bug.cgi?id=81414
+
+        Reviewed by Vsevolod Vlasov.
+
+        * inspector/front-end/CSSStyleModel.js:
+        (WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.setContent):
+        (WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):
+
 2012-03-20  Yury Semikhatsky  <[email protected]>
 
         Web Inspector: provide class name filter for "comparison" view in heap profiler

Modified: trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js (111383 => 111384)


--- trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js	2012-03-20 12:01:26 UTC (rev 111383)
+++ trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js	2012-03-20 12:17:26 UTC (rev 111384)
@@ -875,7 +875,7 @@
                 return;
 
             var resource = WebInspector.resourceForURL(url);
-            if (!resource)
+            if (!resource || resource.type !== WebInspector.Resource.Type.Stylesheet)
                 return;
 
             var majorChange = event.data.majorChange;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to