Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 89951b32909ed64637882b283ddf0853b64ef7ad
https://github.com/WebKit/WebKit/commit/89951b32909ed64637882b283ddf0853b64ef7ad
Author: Kimmo Kinnunen <[email protected]>
Date: 2024-09-12 (Thu, 12 Sep 2024)
Changed paths:
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/platform/graphics/GraphicsContextGL.h
M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h
M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
M
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp
M
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h
M
Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm
Log Message:
-----------
GraphicsContextGL::copyTextureFromMedia is redundant function
https://bugs.webkit.org/show_bug.cgi?id=279591
rdar://135868878
Reviewed by Dan Glastonbury.
GraphicsContextGL::copyTextureForMedia is redundant function, all
implemented codepaths end up obtaining VideoFrame out of the
MediaPlayer and using GraphicsContextGL::copyTextureFromVideoTexture
Remove the function.
Mark GraphicsContextGL::copyTextureFromVideoTexture() as pure virtual
to avoid cases where it is not implemented by mistake.
Move the Cocoa implementation from RemoteGraphicsContextGLCocoa to
GraphicsContextGLCocoa, because GraphicsContextGLCocoa lacked the
implementation.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::texImageSource):
* Source/WebCore/platform/graphics/GraphicsContextGL.h:
(WebCore::GraphicsContextGL::copyTextureFromVideoFrame): Deleted.
* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h:
* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLCocoa::cvContext):
(WebCore::GraphicsContextGLCocoa::copyTextureFromVideoFrame):
(WebCore::GraphicsContextGLCocoa::asCV): Deleted.
(WebCore::GraphicsContextGLCocoa::copyTextureFromMedia): Deleted.
*
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLTextureMapperANGLE::copyTextureFromVideoFrame):
(WebCore::GraphicsContextGLTextureMapperANGLE::copyTextureFromMedia): Deleted.
* Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
(WebKit::RemoteGraphicsContextGL::copyTextureFromVideoFrame):
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::copyTextureFromMedia): Deleted.
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
*
Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm:
Canonical link: https://commits.webkit.org/283599@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
