Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6ddc6a2f2f12910ec32834a1dc70b93ab8ce0aeb
https://github.com/WebKit/WebKit/commit/6ddc6a2f2f12910ec32834a1dc70b93ab8ce0aeb
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2024-09-13 (Fri, 13 Sep 2024)
Changed paths:
M Tools/Scripts/update-webkitgtk-libs
M Tools/Scripts/update-webkitwpe-libs
Log Message:
-----------
REGRESSION(283334@main): [GLIB] Script for updating third-party libs does not
work anymore for flatpak
https://bugs.webkit.org/show_bug.cgi?id=279660
Reviewed by Nikolas Zimmermann.
Since 283334@main the scripts update-webkitgtk-libs and update-webkitwpe-libs
do nothing when using flatpak, this is because the call to the script
update-webkit-flatpak is now inside now a condition shouldUseFlatpak() that is
always false at the invocation of that script due to this two reasons:
1. The subroutine shouldUseFlatpak() returns false if the port name is not
specified, and this two scripts are usually called without parameters.
2. Even if you call the script as in "update-webkitgtk-libs --gtk" then the
subroutine shouldUseFlatpak() will only return true if the user flatpak
is already installed, but it will not return true on the first run
(aka no WebKitBuild dir) and we want to default to using flatpak unless
the environment tells us to do something different.
* Tools/Scripts/update-webkitgtk-libs:
* Tools/Scripts/update-webkitwpe-libs:
Canonical link: https://commits.webkit.org/283621@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
