Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 056cae6be886c017d226ccd7de1a40e940febcd2
https://github.com/WebKit/WebKit/commit/056cae6be886c017d226ccd7de1a40e940febcd2
Author: Timothy Hatcher <[email protected]>
Date: 2024-09-17 (Tue, 17 Sep 2024)
Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm
Log Message:
-----------
REGRESSION(283662@main): Web Extensions display strings are being returned
unlocalized.
https://webkit.org/b/279829
rdar://136106148
Reviewed by Brian Weinstein.
The regressed with https://commits.webkit.org/283662@main. We need to create
the m_manifestJSON
object after localization so it has the localized strings.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::parseManifest): Create m_manifestJSON after localization.
(WebKit::WebExtension::manifest): Moved localization steps to parseManifest().
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST(WKWebExtension, DisplayStringParsingWithLocalization)):
Added.
Canonical link: https://commits.webkit.org/283788@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
