Title: [111444] trunk/Source/WebCore
- Revision
- 111444
- Author
- [email protected]
- Date
- 2012-03-20 14:54:15 -0700 (Tue, 20 Mar 2012)
Log Message
Remove unused CSSPrimitiveValue constructors.
<http://webkit.org/b/81695>
Reviewed by Antti Koivisto.
Kill off CSSPrimitiveValue constructors that aren't used anywhere.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValueBase):
(WebCore::CSSPrimitiveValueBase::CSSPrimitiveValueBase):
(CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (111443 => 111444)
--- trunk/Source/WebCore/ChangeLog 2012-03-20 21:42:23 UTC (rev 111443)
+++ trunk/Source/WebCore/ChangeLog 2012-03-20 21:54:15 UTC (rev 111444)
@@ -1,3 +1,20 @@
+2012-03-20 Andreas Kling <[email protected]>
+
+ Remove unused CSSPrimitiveValue constructors.
+ <http://webkit.org/b/81695>
+
+ Reviewed by Antti Koivisto.
+
+ Kill off CSSPrimitiveValue constructors that aren't used anywhere.
+
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ * css/CSSPrimitiveValue.h:
+ (CSSPrimitiveValueBase):
+ (WebCore::CSSPrimitiveValueBase::CSSPrimitiveValueBase):
+ (CSSPrimitiveValue):
+ * css/CSSPrimitiveValueMappings.h:
+
2012-03-20 Sami Kyostila <[email protected]>
Reuse buffer allocation if canvas size does not change
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (111443 => 111444)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2012-03-20 21:42:23 UTC (rev 111443)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2012-03-20 21:54:15 UTC (rev 111444)
@@ -190,11 +190,6 @@
return nullAtom;
}
-CSSPrimitiveValue::CSSPrimitiveValue()
- : CSSValue(PrimitiveClass)
-{
-}
-
CSSPrimitiveValue::CSSPrimitiveValue(int ident)
: CSSValue(PrimitiveClass)
{
@@ -202,13 +197,6 @@
m_value.ident = ident;
}
-CSSPrimitiveValue::CSSPrimitiveValue(ClassType classType, int ident)
- : CSSValue(classType)
-{
- m_primitiveUnitType = CSS_IDENT;
- m_value.ident = ident;
-}
-
CSSPrimitiveValue::CSSPrimitiveValue(double num, UnitTypes type)
: CSSValue(PrimitiveClass)
{
@@ -226,14 +214,6 @@
}
-CSSPrimitiveValue::CSSPrimitiveValue(ClassType classType, const String& str, UnitTypes type)
- : CSSValue(classType)
-{
- m_primitiveUnitType = type;
- if ((m_value.string = str.impl()))
- m_value.string->ref();
-}
-
CSSPrimitiveValue::CSSPrimitiveValue(RGBA32 color)
: CSSValue(PrimitiveClass)
{
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (111443 => 111444)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.h 2012-03-20 21:42:23 UTC (rev 111443)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h 2012-03-20 21:54:15 UTC (rev 111444)
@@ -268,12 +268,7 @@
void addSubresourceStyleURLs(ListHashSet<KURL>&, const CSSStyleSheet*);
-protected:
- CSSPrimitiveValue(ClassType, int ident);
- CSSPrimitiveValue(ClassType, const String&, UnitTypes);
-
private:
- CSSPrimitiveValue();
// FIXME: int vs. unsigned overloading is too subtle to distinguish the color and identifier cases.
CSSPrimitiveValue(int ident);
CSSPrimitiveValue(unsigned color); // RGB value
@@ -298,10 +293,6 @@
static void create(unsigned); // compile-time guard
template<typename T> operator T*(); // compile-time guard
- static PassRefPtr<CSSPrimitiveValue> createUncachedIdentifier(int identifier);
- static PassRefPtr<CSSPrimitiveValue> createUncachedColor(unsigned rgbValue);
- static PassRefPtr<CSSPrimitiveValue> createUncached(double value, UnitTypes type);
-
static UnitTypes canonicalUnitTypeForCategory(UnitCategory category);
void init(PassRefPtr<Counter>);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
