Skip to site navigation (Press enter)
[webkit-changes] [WebKit/WebKit] 6b79ff: [site-isolation] Cross origin
s should not...</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=webkit-changes@lists.webkit.org&q=from:%22mattwoodrow%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">mattwoodrow</span></span></a></span> <span class="date"><a href="/search?l=webkit-changes@lists.webkit.org&q=date:20240923" rel="nofollow">Mon, 23 Sep 2024 19:36:45 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> Branch: refs/heads/main Home: <a rel="nofollow" href="https://github.com/WebKit/WebKit">https://github.com/WebKit/WebKit</a> Commit: 6b79ff056204ba9eb5d90e85fdeb7117015f39a6 <a rel="nofollow" href="https://github.com/WebKit/WebKit/commit/6b79ff056204ba9eb5d90e85fdeb7117015f39a6">https://github.com/WebKit/WebKit/commit/6b79ff056204ba9eb5d90e85fdeb7117015f39a6</a> Author: Matt Woodrow <mattwood...@apple.com> Date: 2024-09-23 (Mon, 23 Sep 2024)</pre><pre> Changed paths: A LayoutTests/http/tests/site-isolation/basic-transparent-iframe-expected.html A LayoutTests/http/tests/site-isolation/basic-transparent-iframe.html M LayoutTests/http/tests/site-isolation/draw-with-size-after-same-origin-navigation.html M LayoutTests/http/tests/site-isolation/page-zoom.html A LayoutTests/http/tests/site-isolation/resources/no-background.html M LayoutTests/http/tests/site-isolation/selection-focus.html M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderLayerCompositor.h M Source/WebCore/rendering/RenderView.cpp Log Message: ----------- [site-isolation] Cross origin <iframe>s should not (usually) draw a background color. <a rel="nofollow" href="https://bugs.webkit.org/show_bug.cgi?id=279954">https://bugs.webkit.org/show_bug.cgi?id=279954</a> <rdar://136270045> Reviewed by Simon Fraser. Adds 'isMainFrameCompositor' to RenderLayerCompositor to distinguish between actual main-frame compositors, vs process root ones. Use this to avoid setting a lot of extra layers that should only been needed on the actual main frame (like the overhang areas layer for overscroll). Also fixes RenderView::shouldPaintBaseBackground() to detect being a main-frame using the Frame hierarchy instead of checking for an owner element. This is still somewhat wrong, since it wants the owner element to check for a 'frame' tag, which can't be done cross-process. * LayoutTests/http/tests/site-isolation/basic-transparent-iframe-expected.html: Added. * LayoutTests/http/tests/site-isolation/basic-transparent-iframe.html: Added. * LayoutTests/http/tests/site-isolation/resources/no-background.html: Added. * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): (WebCore::RenderLayerCompositor::isAsyncScrollableStickyLayer const): (WebCore::RenderLayerCompositor::requiresScrollLayer const): (WebCore::RenderLayerCompositor::isMainFrameCompositor const): (WebCore::RenderLayerCompositor::shouldCompositeOverflowControls const): (WebCore::RenderLayerCompositor::requiresOverhangAreasLayer const): (WebCore::RenderLayerCompositor::requiresContentShadowLayer const): (WebCore::RenderLayerCompositor::updateLayerForTopOverhangArea): (WebCore::RenderLayerCompositor::updateLayerForBottomOverhangArea): (WebCore::RenderLayerCompositor::updateLayerForHeader): (WebCore::RenderLayerCompositor::updateLayerForFooter): * Source/WebCore/rendering/RenderLayerCompositor.h: * Source/WebCore/rendering/RenderView.cpp: (WebCore::RenderView::shouldPaintBaseBackground const): Canonical link: <a rel="nofollow" href="https://commits.webkit.org/284131@main">https://commits.webkit.org/284131@main</a> To unsubscribe from these emails, change your notification settings at <a rel="nofollow" href="https://github.com/WebKit/WebKit/settings/notifications">https://github.com/WebKit/WebKit/settings/notifications</a> _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org <a rel="nofollow" href="https://lists.webkit.org/mailman/listinfo/webkit-changes">https://lists.webkit.org/mailman/listinfo/webkit-changes</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg219968.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#219969">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#219969">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg219970.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[webkit-changes] [WebKit/WebKit] 6b79ff: [site-isolation] Cross origin <iframe>s should not..."> <input type="hidden" name="msgid" value="WebKit/WebKit/push/refs/heads/main/97db16-6b79ff@github.com"> <input type="hidden" name="relpath" value="webkit-changes@lists.webkit.org/msg219969.html"> <input type="submit" value=" mattwoodrow "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="webkit-changes@lists.webkit.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search webkit-changes"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/webkit-changes@lists.webkit.org/">webkit-changes - all messages</a></li> <li class="icons-about"><a href="/webkit-changes@lists.webkit.org/info.html">webkit-changes - about the list</a></li> <li class="icons-expand"><a href="/search?l=webkit-changes@lists.webkit.org&q=subject:%22%5C%5Bwebkit%5C-changes%5C%5D+%5C%5BWebKit%5C%2FWebKit%5C%5D+6b79ff%5C%3A+%5C%5Bsite%5C-isolation%5C%5D+Cross+origin+%3Ciframe%3Es+should+not...%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg219968.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg219970.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">WebKit/WebKit/push/refs/heads/main/97db16-6b79ff@github.com</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9db71845883d4afc',t:'MTc3MzM2MzU1NA=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>